Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure during manifest setup #1650

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Fix failure during manifest setup #1650

merged 3 commits into from
Jan 8, 2024

Conversation

DimaStebaev
Copy link
Contributor

@DimaStebaev DimaStebaev commented Jan 8, 2024 •
edited
Loading

  • resolve promises
  • fix manifest filename
  • remove manifest manipulations from mainnet upgrade script

Resolves #1612

@DimaStebaev DimaStebaev changed the base branch from develop to v2.1.0 January 8, 2024 14:50
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b7ef7d) 85.79% compared to head (3d686df) 85.79%.

❗ Current head 3d686df differs from pull request most recent head 31c4710. Consider uploading reports for the commit 31c4710 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           v2.1.0    #1650   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files          26       26           
  Lines        1464     1464           
  Branches      401      401           
=======================================
  Hits         1256     1256           
  Misses         33       33           
  Partials      175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DimaStebaev DimaStebaev marked this pull request as ready for review January 8, 2024 16:46
payvint
payvint approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@payvint payvint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising

@DimaStebaev DimaStebaev merged commit 05c7edd into v2.1.0 Jan 8, 2024
7 checks passed
@DimaStebaev DimaStebaev deleted the 1612-manifest branch January 8, 2024 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@payvint payvint payvint approved these changes

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@yavrsky yavrsky yavrsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure during manifest setup
4 participants
@DimaStebaev @payvint @DmytroNazarenko @yavrsky